kaka11chen opened a new pull request, #50744:
URL: https://github.com/apache/doris/pull/50744
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
Fix complex type late materialization. Original logic for `computeRGIdx()`
has bugs, it will return wrong result when `rowIdx = 0`. But this error does
not affect the correctness of most cases.
In order to solve this problem，currently refactor the entire delayed
materialized node filtering mechanism.
Currently Filter/Non Filter Node types:
```
/**
* Filter Node Types:
*
* FILTER_CHILD: Primitive type that is a filter column.
* FILTER_PARENT: Compound type that may contain both filter and
non-filter children.
* FILTER_COMPOUND_ELEMENT: Compound type that is a filter element
(list/map).
* The entire column will be read, and must have
only filter children.
* NON_FILTER: Non-filter column.
*
* Example:
* struct<name:string,
* age:int,
* address:struct<city:string,
* zip:int,
* location:struct<latitude:double,
longitude:double>>,
* hobbies:list<struct<name:string, level:int>>,
* scores:map<string, struct<subject:string, grade:int>>>
*
* Filter columns: name, address.city, address.location.latitude, hobbies,
scores
*
* Column Structure:
* struct<...>
* ├── name (FILTER_CHILD) # Primitive type, filter column
* ├── age (NON_FILTER) # Non-filter column
* ├── address (FILTER_PARENT) # Compound type with filter children
* │ ├── city (FILTER_CHILD) # Primitive type, filter column
* │ ├── zip (NON_FILTER) # Non-filter column
* │ └── location (FILTER_PARENT) # Compound type with filter children
* │ ├── latitude (FILTER_CHILD) # Primitive type, filter column
* │ └── longitude (NON_FILTER) # Non-filter column
* ├── hobbies (FILTER_COMPOUND_ELEMENT) # Compound type as filter
element (list)
* │ └── struct<name:string, level:int> (FILTER_PARENT) # Compound type
with filter children
* │ ├── name (FILTER_CHILD) # Primitive type, filter column
* │ └── level (FILTER_CHILD) # Primitive type, filter column
* └── scores (FILTER_COMPOUND_ELEMENT) # Compound type as filter
element (map)
* ├── key (FILTER_CHILD) # Primitive type, filter column
* └── value (FILTER_PARENT) # Compound type with filter children
* ├── subject (FILTER_CHILD) # Primitive type, filter column
* └── grade (FILTER_CHILD) # Primitive type, filter column
*/
```
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
