englefly commented on code in PR #11209:
URL: https://github.com/apache/doris/pull/11209#discussion_r930831997
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -119,6 +119,12 @@ sortItem
: expression ordering = (ASC | DESC)?
;
+limitClause
+ : (LIMIT INTEGER_VALUE)?
+ | (LIMIT INTEGER_VALUE OFFSET INTEGER_VALUE)?
+ | (LIMIT INTEGER_VALUE COMMA INTEGER_VALUE)?
Review Comment:
`select * from t order by a limit 100, 3`
is equivalent to
`select * from t order by a limit 3 offset 100`
we should follow our `cup` definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
