yujun777 opened a new pull request, #49774:
URL: https://github.com/apache/doris/pull/49774
### What problem does this PR solve?
ExtractCommonFactorRule will split AND into CNFs(conjuncts), and for each
CNF, it split the CNF into multiple DNFs (disconjuctions) , it pick the
common expression and non-common expressions in the DNFs, then for the
non-common expressions it will recursive apply the ExtractCommonFactorRule,
but for the common expressions part it forget to apply the
ExtractCommonFactorRule recursively.
This PR fix this.
for example: for sql `a = 1 and (b = 1 and c = 1 and d < 1 or c = 1 and b =
1 and d > 4)`, this is an AND expression, for the second CNF, there's no
non-common factor part, and the common factor part is `Set({b = 1 and c = 1 and
d < 1}, {c = 1 and b = 1 and d > 4})`, it need to recursive
ExtractCommonFactorRule for the combine of them `b = 1 and c = 1 and d < 1 OR
c = 1 and b = 1 and d > 4`, then rewrite it to `b = 1 and c = 1 and (d < 1 or d
> 4)`, at last, we will get final result `a = 1 and b = 1 and c = 1 and (d <
1 or d > 4)`
This PR also delete function ExpressionUtil.combineAsLeftDeepTree.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
