seawinde commented on code in PR #50775: URL: https://github.com/apache/doris/pull/50775#discussion_r2084081686
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/BoolOr.java: ########## @@ -0,0 +1,94 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.agg; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.functions.CustomSignature; +import org.apache.doris.nereids.trees.expressions.functions.Function; +import org.apache.doris.nereids.trees.expressions.shape.UnaryExpression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.BooleanType; +import org.apache.doris.nereids.types.DataType; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; + +import java.util.List; + +/** + * AggregateFunction 'bool_or'. + */ +public class BoolOr extends NullableAggregateFunction implements UnaryExpression, CustomSignature, RollUpTrait { + public BoolOr(Expression child) { + this(false, false, child); + } + + public BoolOr(boolean distinct, Expression arg) { + this(distinct, false, arg); + } + + private BoolOr(boolean distinct, boolean alwaysNullable, Expression arg) { + super("bool_or", false, alwaysNullable, arg); + } + + @Override + public void checkLegalityBeforeTypeCoercion() { + if (!getArgumentType(0).isBooleanType()) { + throw new AnalysisException("bool_or only accepts BOOLEAN type."); + } + } + + @Override + public FunctionSignature customSignature() { + return FunctionSignature.ret(BooleanType.INSTANCE).args(BooleanType.INSTANCE); + } + + @Override + protected List<DataType> intermediateTypes() { + return ImmutableList.of(getDataType()); + } + + @Override + public BoolOr withDistinctAndChildren(boolean distinct, List<Expression> children) { + Preconditions.checkArgument(children.size() == 1); + return new BoolOr(distinct, alwaysNullable, children.get(0)); + } + + @Override + public NullableAggregateFunction withAlwaysNullable(boolean alwaysNullable) { + return new BoolOr(distinct, alwaysNullable, children.get(0)); + } + + @Override + public <R, C> R accept(ExpressionVisitor<R, C> visitor, C context) { + return visitor.visitBoolOr(this, context); + } + + @Override + public Function constructRollUp(Expression param, Expression... varParams) { + return new BoolOr(this.distinct, this.alwaysNullable, param); + } + + @Override + public boolean canRollUp() { + return true; Review Comment: canRollUp indicates whether a function can be rolled up (aggregated hierarchically). For example, the materialized view mv1 is defined as: ```sql SELECT a, b, bool_or(c) FROM t1 GROUP BY a, b; ``` If a query is: ```sql SELECT a, bool_or(c) FROM t1 GROUP BY a; ``` can this query be answered using mv1? Based on the roll-up property of bool_or, the answer is yes. Specifically: SELECT a, bool_or(c) FROM mv1 GROUP BY a; is logically equivalent to SELECT a, bool_or(c) FROM t1 GROUP BY a;. Additional test cases should be added to validate this behavior, such as in doris/regression-test/suites/nereids_rules_p0/mv/agg_with_roll_up/aggregate_with_roll_up.groovy, following the pattern of mv14_0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
