xiaokang commented on code in PR #10694:
URL: https://github.com/apache/doris/pull/10694#discussion_r931691730
##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -111,9 +112,10 @@ Status BetaRowsetReader::init(RowsetReaderContext*
read_context) {
RowwiseIterator* final_iterator;
if (config::enable_storage_vectorization && read_context->is_vec) {
if (read_context->need_ordered_result &&
Review Comment:
removed read_context->read_orderby_key and optimized the
new_merge_iterator/new_union_iterator as we discussed.
##########
be/src/vec/olap/vcollect_iterator.cpp:
##########
@@ -145,7 +150,7 @@ bool
VCollectIterator::LevelIteratorComparator::operator()(LevelIterator* lhs, L
bool lower = (cmp_res != 0) ? (cmp_res < 0) : (lhs->version() <
rhs->version());
lower ? lhs->set_same(true) : rhs->set_same(true);
- return lower;
+ return UNLIKELY(_is_reverse) ? !lower : lower;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
