mymeiyi commented on code in PR #49822:
URL: https://github.com/apache/doris/pull/49822#discussion_r2084403862
##########
be/src/pipeline/exec/group_commit_scan_operator.cpp:
##########
@@ -46,8 +45,21 @@ Status GroupCommitLocalState::init(RuntimeState* state,
LocalStateInfo& info) {
auto& p = _parent->cast<GroupCommitOperatorX>();
_get_block_dependency = Dependency::create_shared(_parent->operator_id(),
_parent->node_id(),
"GroupCommitGetBlockDependency", true);
- return state->exec_env()->group_commit_mgr()->get_load_block_queue(
+ _timer_dependency = Dependency::create_shared(_parent->operator_id(),
_parent->node_id(),
+
"GroupCommitTimerDependency", true);
+ auto st = state->exec_env()->group_commit_mgr()->get_load_block_queue(
p._table_id, state->fragment_instance_id(), load_block_queue,
_get_block_dependency);
+ if (st.ok()) {
+ DCHECK(load_block_queue != nullptr);
+ _timer_dependency->block();
+ _runtime_filter_timer = std::make_shared<pipeline::RuntimeFilterTimer>(
+ MonotonicMillis(),
load_block_queue->get_group_commit_interval_ms(),
+ _timer_dependency);
+ std::vector<std::shared_ptr<pipeline::RuntimeFilterTimer>> timers;
Review Comment:
group commit需要按照提交时间被唤醒，现在只有runtime filter支持这种
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
