gavinchou commented on code in PR #50820:
URL: https://github.com/apache/doris/pull/50820#discussion_r2085809488
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -3504,7 +3504,11 @@ public static int metaServiceRpcRetryTimes() {
"In cloud mode, the retry number when the FE requests the meta
service times out is 1 by default"})
public static int meta_service_rpc_timeout_retry_times = 1;
- // ATTN: DONOT add any config not related to cloud mode here
+ @ConfField(description =
{"存算分离模式下FE启动后，fe是否等待CloudTabletStatMgr从ms同步完成一次tablet stat信息，默认为true",
+ "After FE starts in cloud mode, does FE wait for CloudTabletStatMgr to
synchronize the tablet stat information "
+ + "from MS once? The default value is true"})
+ public static boolean cloud_enable_wait_tablet_stat_sync = true;
Review Comment:
naming enable_xxx
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudEnv.java:
##########
@@ -457,4 +458,30 @@ public void dropFrontend(FrontendNodeType role, String
host, int port) throws Dd
public void modifyFrontendHostName(String srcHost, int srcPort, String
destHost) throws DdlException {
throw new DdlException("Modifying frontend hostname is not supported
in cloud mode");
}
+
+ // wait until FE is ready.
+ public void waitForReady() throws InterruptedException {
+ long counter = 0;
Review Comment:
should not wait here, it may block FE starts even if we dont need to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
