zhiqiang-hhhh commented on code in PR #50996:
URL: https://github.com/apache/doris/pull/50996#discussion_r2094807647
##########
be/src/olap/schema.cpp:
##########
@@ -124,7 +124,8 @@ Schema::~Schema() {
}
vectorized::DataTypePtr Schema::get_data_type_ptr(const Field& field) {
- return vectorized::DataTypeFactory::instance().create_data_type(field);
+ return
vectorized::DataTypeFactory::instance().create_data_type(field.get_desc(),
+
field.is_nullable());
Review Comment:
no，original function interface is just a wrapper，it is same with code after
modification. it is only used at here，so i removed a interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
