liaoxin01 commented on code in PR #11289:
URL: https://github.com/apache/doris/pull/11289#discussion_r932187033
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +734,45 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
return Status::OK();
}
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset, but the
Review Comment:
fixed
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +734,45 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
return Status::OK();
}
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset, but the
+// detele bitmap of origin rowset may update when compaction.
+// some key deleted on compaction will exist in dst rowset.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
