gavinchou commented on code in PR #51045:
URL: https://github.com/apache/doris/pull/51045#discussion_r2095956808


##########
cloud/src/recycler/recycler.cpp:
##########
@@ -2640,7 +2640,11 @@ int InstanceRecycler::recycle_expired_txn_label() {
         err = txn->commit();
         if (err != TxnErrorCode::TXN_OK) {
             LOG(WARNING) << "failed to delete expired txn, err=" << err << " 
key=" << hex(k);
-            return -1;
+            // When TXN_CONFLICT occurs, the txn label key will not be deleted,

Review Comment:
   we should not make it tricky, failure is failure. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to