This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new eb4721cd80 [enhance](*): replace with StringBuild (#11146)
eb4721cd80 is described below
commit eb4721cd80f86cebd8b9086ff9cd3ef86b31354d
Author: jakevin <[email protected]>
AuthorDate: Fri Jul 29 14:31:35 2022 +0800
[enhance](*): replace with StringBuild (#11146)
---
fe/fe-core/src/main/cup/sql_parser.cup | 2 +-
.../org/apache/doris/analysis/AlterPolicyStmt.java | 2 +-
.../apache/doris/analysis/AlterResourceStmt.java | 2 +-
.../java/org/apache/doris/analysis/Separator.java | 2 +-
.../java/org/apache/doris/catalog/Replica.java | 2 +-
.../doris/httpv2/rest/manager/NodeAction.java | 2 +-
.../org/apache/doris/httpv2/util/HttpUtil.java | 23 +---------------------
.../org/apache/doris/planner/QueryPlanTest.java | 3 +--
.../org/apache/doris/planner/RepeatNodeTest.java | 2 +-
9 files changed, 9 insertions(+), 31 deletions(-)
diff --git a/fe/fe-core/src/main/cup/sql_parser.cup
b/fe/fe-core/src/main/cup/sql_parser.cup
index 16e2bac79b..985bd1d15d 100644
--- a/fe/fe-core/src/main/cup/sql_parser.cup
+++ b/fe/fe-core/src/main/cup/sql_parser.cup
@@ -147,7 +147,7 @@ parser code {:
return null;
}
String[] lines = stmt.split("\n", -1);
- StringBuffer result = new StringBuffer();
+ StringBuilder result = new StringBuilder();
result.append(getErrorTypeMessage(errorToken.sym) + " in line ");
result.append(errorToken.left);
result.append(":\n");
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/AlterPolicyStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/AlterPolicyStmt.java
index bb45ac9bd3..ae3fb503e4 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/AlterPolicyStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/AlterPolicyStmt.java
@@ -139,7 +139,7 @@ public class AlterPolicyStmt extends DdlStmt {
@Override
public String toSql() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("ALTER POLICY '").append(policyName).append("' ");
sb.append("PROPERTIES(").append(new PrintableMap<>(properties, " = ",
true, false)).append(")");
return sb.toString();
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/AlterResourceStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/AlterResourceStmt.java
index d93e06d071..802b4b9bfb 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/AlterResourceStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/AlterResourceStmt.java
@@ -77,7 +77,7 @@ public class AlterResourceStmt extends DdlStmt {
@Override
public String toSql() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("ALTER RESOURCE '").append(resourceName).append("' ");
sb.append("PROPERTIES(").append(new PrintableMap<>(properties, " = ",
true, false)).append(")");
return sb.toString();
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/Separator.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/Separator.java
index c8c096d081..3a5731944a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/Separator.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/Separator.java
@@ -101,7 +101,7 @@ public class Separator implements ParseNode {
// unescape some invisible string literal to char, such as "/t" to char
'/t'
private static String unescape(String orig) {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
boolean hadSlash = false;
for (int i = 0; i < orig.length(); i++) {
char ch = orig.charAt(i);
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java
index febf9fb399..b65eb91486 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java
@@ -431,7 +431,7 @@ public class Replica implements Writable {
@Override
public String toString() {
- StringBuffer strBuffer = new StringBuffer("[replicaId=");
+ StringBuilder strBuffer = new StringBuilder("[replicaId=");
strBuffer.append(id);
strBuffer.append(", BackendId=");
strBuffer.append(backendId);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/manager/NodeAction.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/manager/NodeAction.java
index add8d304e4..78eec49c51 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/manager/NodeAction.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/manager/NodeAction.java
@@ -554,7 +554,7 @@ public class NodeAction extends RestBaseController {
}
private String concatFeSetConfigUrl(NodeConfigs nodeConfigs, boolean
isPersist) {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
Pair<String, Integer> hostPort = nodeConfigs.getHostPort();
sb.append("http://";).append(hostPort.first).append(":").append(hostPort.second).append("/api/_set_config");
Map<String, String> configs = nodeConfigs.getConfigs(isPersist);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/util/HttpUtil.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/util/HttpUtil.java
index a9c10e84de..a2e0c91063 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/httpv2/util/HttpUtil.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/httpv2/util/HttpUtil.java
@@ -17,34 +17,13 @@
package org.apache.doris.httpv2.util;
-import com.google.common.base.Strings;
-import org.springframework.http.HttpHeaders;
-
import java.io.BufferedReader;
import java.io.IOException;
import javax.servlet.http.HttpServletRequest;
public class HttpUtil {
- public static boolean isKeepAlive(HttpServletRequest request) {
- if (!request.getHeader(HttpHeaders.CONNECTION).equals("close")
- && (request.getProtocol().equals("")
- ||
request.getHeader(HttpHeaders.CONNECTION).equals("keep-alive"))) {
- return true;
- }
- return false;
- }
-
- public static boolean isSslEnable(HttpServletRequest request) {
- String url = request.getRequestURL().toString();
- if (!Strings.isNullOrEmpty(url) && url.startsWith("https")) {
- return true;
- }
- return false;
-
- }
-
public static String getBody(HttpServletRequest request) {
- StringBuffer data = new StringBuffer();
+ StringBuilder data = new StringBuilder();
String line = null;
BufferedReader reader = null;
try {
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
b/fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
index ef7a1d963d..8ed644ebac 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
@@ -1018,7 +1018,6 @@ public class QueryPlanTest extends TestWithFeService {
public void testJoinPredicateTransitivityWithSubqueryInWhereClause()
throws Exception {
connectContext.setDatabase("default_cluster:test");
String sql = "SELECT *\n"
-
+ "FROM test.pushdown_test\n"
+ "WHERE 0 < (\n"
+ " SELECT MAX(k9)\n" + " FROM test.pushdown_test);";
@@ -1037,7 +1036,7 @@ public class QueryPlanTest extends TestWithFeService {
}
@Test
- public void testConstInParitionPrune() throws Exception {
+ public void testConstInPartitionPrune() throws Exception {
FeConstants.runningUnitTest = true;
String queryStr = "explain select * from (select 'aa' as kk1, sum(id)
from test.join1 where dt = 9"
+ " group by kk1)tt where kk1 in ('aa');";
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/planner/RepeatNodeTest.java
b/fe/fe-core/src/test/java/org/apache/doris/planner/RepeatNodeTest.java
index de5120f41c..9e6f5f6027 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/planner/RepeatNodeTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/planner/RepeatNodeTest.java
@@ -81,7 +81,7 @@ public class RepeatNodeTest {
}
@Test
- public void testNornal() {
+ public void testNormal() {
try {
TPlanNode msg = new TPlanNode();
node.toThrift(msg);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
