BiteTheDDDDt commented on PR #11353:
URL: https://github.com/apache/doris/pull/11353#issuecomment-1200146196
brpc will build both shared and static
------------------ Original ------------------
From: yiguolei ***@***.***>
Date: Sat,Jul 30,2022 8:05 PM
To: apache/doris ***@***.***>
Cc: Pxl ***@***.***>, Comment ***@***.***>
Subject: Re: [apache/doris] [fix] fix compile error: missing libbrpc.a (PR
#11353)
@yiguolei commented on this pull request.
In thirdparty/build-thirdparty.sh:
> @@ -345,7 +345,7 @@ build_protobuf() { ldflags="-L${TP_LIB_DIR}
-static-libstdc++ -static-libgcc -Wl,--undefined=pthread_create" fi -
CXXFLAGS="-O2 -I${TP_INCLUDE_DIR}" \+ CXXFLAGS="-fPIC -O2
-I${TP_INCLUDE_DIR}" \
why add -fPIC here? I find pxl do remove it few days ago.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
