eldenmoon commented on code in PR #50907:
URL: https://github.com/apache/doris/pull/50907#discussion_r2098772944


##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:
##########
@@ -133,6 +134,8 @@ public class SchemaChangeJobV2 extends AlterJobV2 {
     private boolean indexChange = false;
     @SerializedName(value = "indexes")
     protected List<Index> indexes = null;
+    @SerializedName(value = "indexDrop")
+    private boolean indexDrop = false;

Review Comment:
   why adding an extra field to indicate indexDrop



##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BuildIndexClause.java:
##########
@@ -35,43 +36,54 @@ public class BuildIndexClause extends AlterTableClause {
     // in which table the index on, only used when alter = false
     private TableName tableName;
     // index definition class
-    private IndexDef indexDef;
+    private List<IndexDef> indexDefList;

Review Comment:
   is ngram bf support build index?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to