zclllyybb commented on code in PR #48720:
URL: https://github.com/apache/doris/pull/48720#discussion_r2111277865
##########
be/src/pipeline/shuffle/writer.cpp:
##########
@@ -85,19 +246,24 @@ Status Writer::_channel_add_rows(RuntimeState* state,
uint32_t start = partition_rows_histogram[i + 1];
uint32_t size = partition_rows_histogram[i + 2] - start;
if (!channels[i]->is_receiver_eof() && size > 0) {
+ VLOG_DEBUG << fmt::format("partition {} of {}, block:\n{}, start:
{}, size: {}", i,
+ partition_count, block->dump_data(),
start, size);
status = channels[i]->add_rows(block, row_idx.data(), start, size,
false);
HANDLE_CHANNEL_STATUS(state, channels[i], status);
}
}
if (eos) {
for (int i = 0; i < partition_count; ++i) {
if (!channels[i]->is_receiver_eof()) {
+ VLOG_DEBUG << fmt::format("EOS partition {} of {},
block:\n{}", i, partition_count,
+ block->dump_data());
status = channels[i]->add_rows(block, row_idx.data(), 0, 0,
true);
HANDLE_CHANNEL_STATUS(state, channels[i], status);
}
}
}
return Status::OK();
}
+// NOLINTEND(readability-function-cognitive-complexity)
Review Comment:
that's for suppressing some warning of function with too many lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]