dolfinus commented on PR #50126: URL: https://github.com/apache/doris/pull/50126#issuecomment-2921679237
May I propose an alternative? This PR can be splitted to a set of smaller ones: * replace `UUID.generateRandomUUID()` to UUIDGenerator class, returning UUIDv4, so behavior remains the same * cover both C++ and Java UUIDv4 generators with unit tests checking value randomness and thread safety. Again, without any behavioral changes. * switch implementation from UUIDv7 to UUIDv4 and add tests for values monotinical increase + timestamp correlation First 2 PRs can be reviewed and merged without any hesitation about performance and implementation complexity. Also diff for each PR will be smalled than now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
