adonis0147 commented on code in PR #11325:
URL: https://github.com/apache/doris/pull/11325#discussion_r934647338
##########
bin/start_be.sh:
##########
@@ -16,11 +16,38 @@
# specific language governing permissions and limitations
# under the License.
-curdir=$(dirname "$0")
-curdir=$(
- cd "$curdir"
- pwd
-)
+#check max_map_count
+MAX_MAP_COUNT=`sysctl -n vm.max_map_count`
Review Comment:
```suggestion
MAX_MAP_COUNT="$(sysctl -n vm.max_map_count)"
```suggestion
It is better to use `$()` rather than ``.
##########
bin/start_be.sh:
##########
@@ -16,11 +16,38 @@
# specific language governing permissions and limitations
# under the License.
-curdir=$(dirname "$0")
-curdir=$(
- cd "$curdir"
- pwd
-)
+#check max_map_count
+MAX_MAP_COUNT=`sysctl -n vm.max_map_count`
+if [ $MAX_MAP_COUNT -lt 2000000 ]; then
Review Comment:
Use `[[]]` to test, otherwise, you should double quote $MAX_MAP_COUNT.
```suggestion
if [[ "${MAX_MAP_COUNT}" -lt 2000000 ]]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
