airborne12 commented on code in PR #51423:
URL: https://github.com/apache/doris/pull/51423#discussion_r2125783329


##########
be/src/olap/like_column_predicate.cpp:
##########
@@ -68,7 +68,7 @@ uint16_t LikeColumnPredicate<T>::_evaluate_inner(const 
vectorized::IColumn& colu
                     sel[new_size] = idx;
                     StringRef cell_value = 
nested_col_ptr->get_shrink_value(data_array[idx]);
                     unsigned char flag = 0;
-                    static_cast<void>((_state->scalar_function)(
+                    THROW_IF_ERROR((_state->scalar_function)(

Review Comment:
   Confirm whether there is a catch block outside the predicate evaluation 
logic. Otherwise, any pattern parsing error may lead to a core dump.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to