yujun777 opened a new pull request, #51569:
URL: https://github.com/apache/doris/pull/51569
### What problem does this PR solve?
For rule ExtractSingleTableExpressionFromDisjunction, it will extract every
single table's expression for LogicalFilter and LogicalJoin. But this is not
enough, for join, it should support extract multiple tables: a expression
for left tables, and a right expression for right tables.
For example:
```sql
(t1 join t2) join ( t3 and t4) on t1.a + t2.a = 1 and t3.x + t4.x = 1 or
t1.a + t2.a = 2 and t3.x + t4.x = 2
```
it can't extract each single table expression for t1, t2, t3, t4.
but for the root join, its left plan is `(t1 join t2)`, we can extract
left plan's expression `t1.a + t2.a = 1 or t1.a + t2.a = 2`.
also for the right plan `(t3 join t4)`, we can extract right plan's
expression `t3.x + t4.x = 1 or t3.x + t4.x = 2`.
Then we can rewrite the root join's conditition as
```
origin_condition AND (t1.a + t2.a = 1 or t1.a + t2.a = 2) AND (t3.x +
t4.x = 1 or t3.x + t4.x = 2)
```
latter, we can push down left plan expression to the left plan expression,
and right plan expression to the right plan expression.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
