englefly commented on code in PR #11459:
URL: https://github.com/apache/doris/pull/11459#discussion_r936364439
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -584,7 +584,7 @@ public LogicalPlan visitFromClause(FromClauseContext ctx) {
LogicalPlan right = plan(relation.relationPrimary());
left = left == null
? right
- : new LogicalJoin(JoinType.INNER_JOIN,
Optional.empty(), left, right);
+ : new LogicalJoin<>(JoinType.CROSS_JOIN,
Optional.empty(), left, right);
Review Comment:
If this is a cross join, I think there must be some place where we change
the default join type (INNER_JOIN) to CROSS_JOIN.
Simllarly, if we change the default join type to CROSS_JOIN, there should be
some place we change join type from CROSS_JOIN to INNER_JOIN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
