zhangstar333 commented on code in PR #51501:
URL: https://github.com/apache/doris/pull/51501#discussion_r2137397490
##########
be/src/vec/functions/function_regexp.cpp:
##########
@@ -50,6 +52,152 @@
namespace doris::vectorized {
#include "common/compile_check_begin.h"
+struct RegexpCountImpl {
+ static void execute_impl(FunctionContext* context, ColumnPtr
argument_columns[],
+ size_t input_rows_count, ColumnInt64::Container&
result_data,
+ NullMap& null_map) {
+ const auto* pattern =
check_and_get_column<ColumnString>(argument_columns[1].get());
+ const auto* str =
check_and_get_column<ColumnString>(argument_columns[0].get());
+
+ for (size_t i = 0; i < input_rows_count; ++i) {
+ if (null_map[i]) {
+ result_data[i] = 0;
+ continue;
+ }
+
+ result_data[i] = _execute_inner_loop(context, str, pattern,
null_map, i);
+ }
+ }
+
+private:
+ static int64_t _execute_inner_loop(FunctionContext* context, const
ColumnString* str,
+ const ColumnString* pattern, NullMap&
null_map,
+ const size_t index_now) {
+ re2::RE2* re = reinterpret_cast<re2::RE2*>(
+ context->get_function_state(FunctionContext::THREAD_LOCAL));
+ std::unique_ptr<re2::RE2> scoped_re;
Review Comment:
not used scoped_re?
and maybe could add check re is not nullptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
