morningman commented on code in PR #51384:
URL: https://github.com/apache/doris/pull/51384#discussion_r2140126725
##########
be/src/vec/sink/writer/iceberg/viceberg_partition_writer.cpp:
##########
@@ -84,10 +83,11 @@ Status VIcebergPartitionWriter::open(RuntimeState* state,
RuntimeProfile* profil
to_string(_compress_type));
}
}
+ VParquetOptions parquetOptions = {parquet_compression_type,
TParquetVersion::PARQUET_1_0,
Review Comment:
`parquet_options`
##########
be/src/vec/sink/writer/vhive_partition_writer.cpp:
##########
@@ -90,10 +89,11 @@ Status VHivePartitionWriter::open(RuntimeState* state,
RuntimeProfile* profile)
to_string(_hive_compress_type));
}
}
+ VParquetOptions parquetOptions = {parquet_compression_type,
TParquetVersion::PARQUET_1_0,
Review Comment:
```suggestion
VParquetOptions parquet_options = {parquet_compression_type,
TParquetVersion::PARQUET_1_0,
```
##########
be/src/vec/runtime/vparquet_transformer.h:
##########
@@ -85,23 +85,28 @@ class ParquetBuildHelper {
const TParquetVersion::type& parquet_version);
};
+struct VParquetOptions {
Review Comment:
```suggestion
struct ParquetOptions {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
