wangshuo128 commented on code in PR #11502:
URL: https://github.com/apache/doris/pull/11502#discussion_r938491743
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -373,6 +375,30 @@ public PlanFragment
visitPhysicalHashJoin(PhysicalHashJoin<Plan, Plan> hashJoin,
}
}
+ @Override
+ public PlanFragment
visitPhysicalNestedLoopJoin(PhysicalNestedLoopJoin<Plan, Plan> nestedLoopJoin,
+ PlanTranslatorContext context) {
+ // NOTICE: We must visit from right to left, to ensure the last
fragment is root fragment
Review Comment:
Should we add a helper method to wrap this logic? Maybe something like
`private List<PlanFragment> postOrderVisitChildren(PhysicalPlan plan,
PlanVisitor visitor, Context context)`.
Could add a todo and refactor this in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
