zhannngchen commented on code in PR #11557:
URL: https://github.com/apache/doris/pull/11557#discussion_r938576177
##########
be/src/olap/rowset/rowset_tree.cpp:
##########
@@ -196,8 +197,13 @@ void RowsetTree::FindRowsetsIntersectingInterval(
}
void RowsetTree::FindRowsetsWithKeyInRange(
- const Slice& encoded_key, vector<std::pair<RowsetSharedPtr, int32_t>>*
rowsets) const {
+ const Slice& encoded_key, const RowsetIdUnorderedSet* rowset_ids,
+ vector<std::pair<RowsetSharedPtr, int32_t>>* rowsets) const {
DCHECK(initted_);
+ DCHECK(rowset_ids != nullptr);
+ for (const auto id : *rowset_ids) {
Review Comment:
forgot to clear?
##########
be/src/olap/memtable.cpp:
##########
@@ -296,7 +300,7 @@ void MemTable::_replace_row(const ContiguousRow& src_row,
TableKey row_in_skipli
// Dest cell already allocated memory, use dirct_copy rather than
deep_copy(which will
Review Comment:
The comment is not suite to current implementation, pls remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
