eldenmoon commented on code in PR #51696:
URL: https://github.com/apache/doris/pull/51696#discussion_r2144304820
##########
be/test/vec/data_types/data_type_object_test.cpp:
##########
@@ -1,449 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
Review Comment:
why remove
##########
be/test/vec/data_types/serde/data_type_serde_object_test.cpp:
##########
@@ -1,225 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
Review Comment:
why remove
##########
be/src/vec/data_types/serde/data_type_object_serde.cpp:
##########
@@ -141,22 +141,9 @@ Status DataTypeVariantSerDe::write_column_to_arrow(const
IColumn& column, const
arrow::ArrayBuilder*
array_builder,
int64_t start, int64_t end,
const cctz::time_zone& ctz)
const {
- const auto* var = check_and_get_column<ColumnVariant>(column);
Review Comment:
maybe change to string impl
##########
run-be-ut.sh:
##########
@@ -468,7 +468,7 @@ if [[ -f "${test}" ]]; then
echo "${cmd1}"
eval "${cmd1}"
cmd2="${LLVM_COV} show -output-dir=${DORIS_TEST_BINARY_DIR}/report
-format=html \
- -show-branches=count -show-expansions
-ignore-filename-regex='(.*gensrc/.*)|(.*be/src/common/status\.h$)|(.*be/src/common/logging.h)|(.*_test\.cpp$)|(.*be/test.*)|(.*apache-orc/.*)|(.*clucene/.*)'
\
Review Comment:
why modify this
##########
be/src/vec/columns/column_variant.cpp:
##########
@@ -282,7 +282,7 @@ Array create_empty_array_field(size_t num_dimensions) {
Array array;
Array* current_array = &array;
for (size_t i = 1; i < num_dimensions; ++i) {
- current_array->push_back(Field::create_field<TYPE_NULL>(Null()));
+ current_array->push_back(Field::create_field<TYPE_ARRAY>(Array()));
Review Comment:
why modify this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
