gavinchou commented on code in PR #49456:
URL: https://github.com/apache/doris/pull/49456#discussion_r2163003648
##########
be/test/io/cache/block_file_cache_test.cpp:
##########
@@ -7083,4 +6993,214 @@ TEST_F(BlockFileCacheTest,
test_evict_cache_in_advance_skip) {
config::file_cache_evict_in_advance_recycle_keys_num_threshold =
origin_threshold;
}
+TEST_F(BlockFileCacheTest, lru_dump) {
Review Comment:
we should check:
1. the dumpped file names
2. the order of the loaded queue from dumpped file, to ensure the order is
the same before dump
3. more UTs should be added to the dump functions, at function level not the
FileCache level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
