zclllyybb commented on code in PR #52100:
URL: https://github.com/apache/doris/pull/52100#discussion_r2173162797
##########
regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_numeric_arithmatic.groovy:
##########
@@ -516,6 +516,9 @@ suite("fold_constant_numeric_arithmatic") {
testFoldConst("SELECT TANH(0) AS tanh_case_1") //tanh(0) = 0
Review Comment:
ohh... I see it. we dont have `@ExecFunction(name = "tanh")` in FE before.
but `testFoldConst` doesn't really check if the there's result generated in FE.
we will try to enhance it in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
