gavinchou commented on code in PR #52551:
URL: https://github.com/apache/doris/pull/52551#discussion_r2177706224
##########
cloud/src/meta-service/txn_kv.h:
##########
@@ -76,11 +78,15 @@ class FullRangeGetIterator {
virtual ~FullRangeGetIterator() = default;
- virtual bool is_valid() = 0;
+ virtual bool is_valid() const = 0;
virtual bool has_next() = 0;
+ virtual TxnErrorCode error_code() const = 0;
+
virtual std::optional<std::pair<std::string_view, std::string_view>>
next() = 0;
+
+ virtual std::optional<std::pair<std::string_view, std::string_view>>
peek() = 0;
Review Comment:
add UT for `peek()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
