yiguolei commented on code in PR #52693:
URL: https://github.com/apache/doris/pull/52693#discussion_r2181205068
##########
be/src/vec/io/io_helper.h:
##########
@@ -200,13 +201,14 @@ inline StringRef read_string_binary_into(Arena& arena,
BufferReadable& buf) {
char* data = arena.alloc(size);
buf.read(data, size);
- return StringRef(data, size);
+ return {data, size};
}
-inline void read_json_binary(JsonbField val, BufferReadable& buf,
+inline void read_json_binary(JsonbField& val, BufferReadable& buf,
size_t MAX_JSON_SIZE = DEFAULT_MAX_JSON_SIZE) {
- StringRef jrf = StringRef {val.get_value(), val.get_size()};
- read_string_binary(jrf, buf);
+ StringRef result;
+ read_string_binary(result, buf);
+ val = JsonbField(result.data, result.size);
Review Comment:
为什么这里要改变val 的值？？？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
