gavinchou commented on code in PR #52430:
URL: https://github.com/apache/doris/pull/52430#discussion_r2182623701
##########
cloud/src/meta-service/keys.cpp:
##########
@@ -22,18 +22,6 @@
namespace doris::cloud {
// clang-format off
-// Prefix
-static const char* INSTANCE_KEY_PREFIX = "instance";
Review Comment:
we can do this anther way without moving these constant:
1. adding a function called `get_key_prefixes()` in .cpp
2. extern declare `get_key_prefixes()` in metrics.cpp
we should keep these key prefixes intact and make it encapsulated inside
keys.cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
