noixcn commented on code in PR #52834:
URL: https://github.com/apache/doris/pull/52834#discussion_r2190375716
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -473,10 +472,7 @@ supportedOtherStatement
| BACKUP SNAPSHOT label=multipartIdentifier TO repo=identifier
((ON | EXCLUDE) LEFT_PAREN baseTableRef (COMMA baseTableRef)*
RIGHT_PAREN)?
properties=propertyClause?
#backup
- ;
-
-unsupportedOtherStatement
- : START TRANSACTION (WITH CONSISTENT SNAPSHOT)?
#unsupportedStartTransaction
+ | START TRANSACTION (WITH CONSISTENT SNAPSHOT)?
#unsupportedStartTransaction
Review Comment:
Hi zclllyybb,
You suggested that I change `unsupportedStartTransaction` to
`startTransaction`.
However, I noticed that changing the rule name seems to affect the
ANTLR-generated code (e.g., the parser and visitor classes). I’ve seen similar
tasks submitted by others, but they didn’t seem to involve any changes to the
generated ANTLR files.
Should I go ahead and regenerate the parser with the new rule name and
include the generated files in my commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
