kaijchen opened a new pull request, #52906:
URL: https://github.com/apache/doris/pull/52906
### What problem does this PR solve?
Related PR: #41018
Problem Summary:
Update the `_need_flush()` function to subtract both `_queue_mem_usage` and
`_flush_mem_usage` when deciding how much memory needs to be flushed.
Previously, we only subtracted `_queue_mem_usage`, which could lead to
flushing more active memtables than necessary.
This change ensures that only the required amount of active memtable memory
is flushed, avoiding premature flushes.
This helps prevent creating small segments, which can hurt performance and
storage efficiency.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
