eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2199384795
##########
regression-test/suites/variant_p0/nested2.groovy:
##########
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
you need to test the conflict
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -776,21 +776,10 @@ public static Boolean
analyzeDisableAutoCompaction(Map<String, String> propertie
}
public static Boolean analyzeVariantFlattenNested(Map<String, String>
properties) throws AnalysisException {
- if (properties == null || properties.isEmpty()) {
Review Comment:
better add a config（default false）， if poc need this
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -776,21 +776,10 @@ public static Boolean
analyzeDisableAutoCompaction(Map<String, String> propertie
}
public static Boolean analyzeVariantFlattenNested(Map<String, String>
properties) throws AnalysisException {
- if (properties == null || properties.isEmpty()) {
Review Comment:
test need to enable the config(session var), see
`disable_inverted_index_v1_for_variant`
##########
regression-test/suites/variant_p0/nested2.groovy:
##########
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
add structure confict cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
