gavinchou commented on code in PR #52677:
URL: https://github.com/apache/doris/pull/52677#discussion_r2199780642
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -2771,28 +2779,36 @@ int InstanceRecycler::recycle_tmp_rowsets() {
return 0;
};
- auto loop_done = [&tmp_rowset_keys, &tmp_rowsets, &num_recycled,
&metrics_context,
- this]() -> int {
+ auto loop_done = [&, this]() -> int {
DORIS_CLOUD_DEFER {
tmp_rowset_keys.clear();
tmp_rowsets.clear();
};
- if (delete_rowset_data(tmp_rowsets, RowsetRecyclingState::TMP_ROWSET,
metrics_context) !=
- 0) {
- LOG(WARNING) << "failed to delete tmp rowset data, instance_id="
<< instance_id_;
- return -1;
- }
- if (txn_remove(txn_kv_.get(), tmp_rowset_keys) != 0) {
- LOG(WARNING) << "failed to delete tmp rowset kv, instance_id=" <<
instance_id_;
- return -1;
- }
- num_recycled += tmp_rowset_keys.size();
+ worker_pool->submit([&, tmp_rowset_keys_to_delete = tmp_rowset_keys,
+ tmp_rowsets_to_delete = tmp_rowsets]() {
+ if (delete_rowset_data(tmp_rowsets_to_delete,
RowsetRecyclingState::TMP_ROWSET,
+ metrics_context) != 0) {
+ LOG(WARNING) << "failed to delete tmp rowset data,
instance_id=" << instance_id_;
+ return;
+ }
+ if (txn_remove(txn_kv_.get(), tmp_rowset_keys_to_delete) != 0) {
+ LOG(WARNING) << "failed to delete tmp rowset kv, instance_id="
<< instance_id_;
+ return;
+ }
+ LOG(INFO) << "finish recycle tmp rowsets, num_recycled="
Review Comment:
too many logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
