This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
     new 883fb539a22 branch-3.0: [fix](job) fix show routine load job result 
incorrect after alter job property #53038 (#53098)
883fb539a22 is described below

commit 883fb539a22b40b7f343a85d828be34d1863c022
Author: github-actions[bot] 
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Sat Jul 12 11:02:28 2025 +0800

    branch-3.0: [fix](job) fix show routine load job result incorrect after 
alter job property #53038 (#53098)
    
    Cherry-picked from #53038
    
    Co-authored-by: hui lai <[email protected]>
---
 .../main/java/org/apache/doris/load/routineload/RoutineLoadJob.java   | 1 +
 regression-test/suites/load_p0/routine_load/test_routine_load.groovy  | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
 
b/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
index d7e3c6fc494..5ea984ebfac 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
@@ -2060,6 +2060,7 @@ public abstract class RoutineLoadJob
         if 
(jobProperties.containsKey(CreateRoutineLoadStmt.MAX_FILTER_RATIO_PROPERTY)) {
             this.maxFilterRatio = Double.parseDouble(
                     
jobProperties.remove(CreateRoutineLoadStmt.MAX_FILTER_RATIO_PROPERTY));
+            
this.jobProperties.put(CreateRoutineLoadStmt.MAX_FILTER_RATIO_PROPERTY, 
String.valueOf(maxFilterRatio));
         }
 
         if 
(jobProperties.containsKey(CreateRoutineLoadStmt.MAX_BATCH_INTERVAL_SEC_PROPERTY))
 {
diff --git 
a/regression-test/suites/load_p0/routine_load/test_routine_load.groovy 
b/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
index 75b8ddce80d..e5a24c2a44c 100644
--- a/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
+++ b/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
@@ -1834,6 +1834,7 @@ suite("test_routine_load","p0") {
                 sql "ALTER ROUTINE LOAD FOR ${jobs[i]} 
PROPERTIES(\"num_as_string\" = \"true\");"
                 sql "ALTER ROUTINE LOAD FOR ${jobs[i]} 
PROPERTIES(\"fuzzy_parse\" = \"true\");"
                 sql "ALTER ROUTINE LOAD FOR ${jobs[i]} 
PROPERTIES(\"workload_group\" = \"alter_routine_load_group\");"
+                sql "ALTER ROUTINE LOAD FOR ${jobs[i]} 
PROPERTIES(\"max_filter_ratio\" = \"0.5\");"
                 res = sql "show routine load for ${jobs[i]}"
                 log.info("routine load job properties: 
${res[0][11].toString()}".toString())
 
@@ -1844,8 +1845,7 @@ suite("test_routine_load","p0") {
                 assertEquals("300001", json.max_batch_rows.toString())
                 assertEquals("209715201", json.max_batch_size.toString())
                 assertEquals("6", json.max_batch_interval.toString())
-                //TODO(bug): Can not update
-                //assertEquals("0.5", json.max_filter_ratio.toString())
+                assertEquals("0.5", json.max_filter_ratio.toString())
                 assertEquals("jsonpaths", json.jsonpaths.toString())
                 assertEquals("json_root", json.json_root.toString())
                 assertEquals("true", json.strict_mode.toString())


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to