amorynan commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2204090829
##########
be/src/service/internal_service.cpp:
##########
@@ -1211,8 +1211,11 @@ void
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcControlle
if (!schemas.empty() && st.ok()) {
// merge all
TabletSchemaSPtr merged_schema;
-
static_cast<void>(vectorized::schema_util::get_least_common_schema(schemas,
nullptr,
-
merged_schema));
+ st = vectorized::schema_util::get_least_common_schema(schemas,
nullptr,
+
merged_schema);
+ if (!st.ok()) {
+ LOG(WARNING) << "Failed to get least common schema: " <<
st.to_string();
Review Comment:
done!
##########
be/src/service/internal_service.cpp:
##########
@@ -1248,8 +1251,11 @@ void
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcControlle
if (!tablet_schemas.empty()) {
// merge all
TabletSchemaSPtr merged_schema;
-
static_cast<void>(vectorized::schema_util::get_least_common_schema(
- tablet_schemas, nullptr, merged_schema));
+ st =
vectorized::schema_util::get_least_common_schema(tablet_schemas, nullptr,
+
merged_schema);
+ if (!st.ok()) {
+ LOG(WARNING) << "Failed to get least common schema: "
<< st.to_string();
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
