w41ter commented on code in PR #53328:
URL: https://github.com/apache/doris/pull/53328#discussion_r2207436200
##########
cloud/src/meta-store/versioned_value.cpp:
##########
@@ -86,20 +86,20 @@ std::tuple<std::string_view, Versionstamp>
VersionedRangeGetIterator::parse_key(
return {key, version};
}
-bool versioned_put(Transaction* txn, std::string_view key, std::string_view
value) {
+void versioned_put(Transaction* txn, std::string_view key, std::string_view
value) {
std::string key_with_versionstamp(key);
uint32_t offset = encode_versionstamp(Versionstamp::min(),
&key_with_versionstamp);
encode_versionstamp_end(&key_with_versionstamp);
- txn->atomic_set_ver_key(key_with_versionstamp, offset, value);
- return true;
+ bool ok = txn->atomic_set_ver_key(key_with_versionstamp, offset, value);
+ DCHECK(ok) << "Atomic set versioned key failed, key: " << hex(key)
Review Comment:
It would not happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
