englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r951313629
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/JoinLAsscomHelper.java:
##########
@@ -165,7 +166,8 @@ private Pair<List<NamedExpression>, List<NamedExpression>>
getProjectExprs() {
private LogicalJoin<GroupPlan, GroupPlan> newBottomJoin() {
return new LogicalJoin(
bottomJoin.getJoinType(),
- Optional.of(ExpressionUtils.and(newBottomJoinOnCondition)),
+ newBottomJoinOnCondition,
+ Optional.empty(),
Review Comment:
In my understanding, LAsscom is used after FindHashConditionForJoin rule.
LAsscom only consider `hashJoinCondition`.
for exmaple:
```
topJoin newTopJoin
/ \ / \
bottomJoin C --> newBottomJoin B
/ \ / \
A B A C
```
The whole process is like this:
1. collect otherJoinCondition of bottomJoin and topJoin in
allOtherJoinCondition
2. run LAsscom only consider hashJoinCondition
3. push allOtherJoinCondition down to newTopJoin and newBottomJoin by
predicatesPushdownThroughJoin rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
