HappenLee commented on code in PR #53271:
URL: https://github.com/apache/doris/pull/53271#discussion_r2210137012
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -249,8 +251,18 @@ void ColumnStruct::update_hashes_with_value(uint64_t*
__restrict hashes,
void ColumnStruct::update_crcs_with_value(uint32_t* __restrict hash,
PrimitiveType type,
uint32_t rows, uint32_t offset,
const uint8_t* __restrict null_data)
const {
- for (const auto& column : columns) {
- column->update_crcs_with_value(hash, type, rows, offset, null_data);
+ auto s = size();
Review Comment:
why change the code? origin seems ok?
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -249,8 +251,18 @@ void ColumnStruct::update_hashes_with_value(uint64_t*
__restrict hashes,
void ColumnStruct::update_crcs_with_value(uint32_t* __restrict hash,
PrimitiveType type,
uint32_t rows, uint32_t offset,
const uint8_t* __restrict null_data)
const {
- for (const auto& column : columns) {
- column->update_crcs_with_value(hash, type, rows, offset, null_data);
+ auto s = size();
Review Comment:
why change the code? origin seems ok?
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -249,8 +251,18 @@ void ColumnStruct::update_hashes_with_value(uint64_t*
__restrict hashes,
void ColumnStruct::update_crcs_with_value(uint32_t* __restrict hash,
PrimitiveType type,
uint32_t rows, uint32_t offset,
const uint8_t* __restrict null_data)
const {
- for (const auto& column : columns) {
- column->update_crcs_with_value(hash, type, rows, offset, null_data);
+ auto s = size();
Review Comment:
why change the code? origin seems ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
