morrySnow commented on code in PR #11971:
URL: https://github.com/apache/doris/pull/11971#discussion_r952111787
##########
fe/fe-core/src/main/java/org/apache/doris/planner/HashJoinNode.java:
##########
@@ -451,13 +453,18 @@ private void computeOutputTuple(Analyzer analyzer) throws
UserException {
outputSlotDesc.setIsNullable(true);
leftNullableNumber++;
}
+ if (needSetToNullable) {
+ outputSlotDesc.setIsNullable(true);
+ }
srcTblRefToOutputTupleSmap.put(new SlotRef(leftSlotDesc),
new SlotRef(outputSlotDesc));
}
}
}
if (copyRight) {
for (TupleDescriptor rightTupleDesc : analyzer.getDescTbl()
.getTupleDesc(getChild(1).getOutputTblRefIds())) {
+ boolean needSetToNullable =
Review Comment:
add some comment to explain why add this local variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
