Copilot commented on code in PR #53371:
URL: https://github.com/apache/doris/pull/53371#discussion_r2211944718
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/metacache/MetaCache.java:
##########
@@ -95,6 +98,10 @@ public Optional<T> getMetaObj(String name, long id) {
if (val != null && val.isPresent()) {
return val;
}
+ if (LOG.isDebugEnabled()) {
+ LOG.info("trigger getMetaObj in metacache {}, obj name:
{}, id: {}",
Review Comment:
[nitpick] Inside an `isDebugEnabled` guard you should use `LOG.debug` rather
than `LOG.info` to match the intended log level.
```suggestion
LOG.debug("trigger getMetaObj in metacache {}, obj name:
{}, id: {}",
```
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/metacache/MetaCache.java:
##########
@@ -138,12 +145,19 @@ public void invalidate(String localName, long id) {
return v;
}
});
+ if (LOG.isDebugEnabled()) {
+ LOG.info("invalidate obj in metacache {}, obj name: {}, id: {}",
Review Comment:
[nitpick] Use `LOG.debug` (not `LOG.info`) when logging under a
`isDebugEnabled` check to align log level with the guard.
```suggestion
LOG.debug("invalidate obj in metacache {}, obj name: {}, id: {}",
```
##########
regression-test/data/external_table_p0/lower_case/test_meta_cache_select_without_refresh.out:
##########
@@ -5,6 +5,9 @@
-- !test_meta_cache_lower_false_select_without_refresh_select_table1 --
1 table1
+-- !sql --
Review Comment:
Directive syntax should be `-- !sql` (without the trailing `--`) to
correctly mark raw SQL in the test output.
```suggestion
-- !sql
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
