gavinchou commented on code in PR #53335:
URL: https://github.com/apache/doris/pull/53335#discussion_r2212023809
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -178,9 +179,9 @@ Status ColumnReader::create_struct(const
ColumnReaderOptions& opts, const Column
// now we support struct column can add the children columns according to
the schema-change behavior
for (size_t i = 0; i < meta.children_columns_size(); i++) {
std::unique_ptr<ColumnReader> sub_reader;
- RETURN_IF_ERROR(ColumnReader::create(opts, meta.children_columns(i),
-
meta.children_columns(i).num_rows(), file_reader,
- &sub_reader));
+ RETURN_IF_ERROR(ColumnReader::create(opts,
meta.children_columns(cast_set<int>(i)),
Review Comment:
why not delare i as `int`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
