yangzhg commented on code in PR #11959:
URL: https://github.com/apache/doris/pull/11959#discussion_r952230504


##########
be/src/util/file_utils.cpp:
##########
@@ -211,6 +211,22 @@ Status FileUtils::md5sum(const std::string& file, 
std::string* md5sum) {
     return Status::OK();
 }
 
+Status FileUtils::mtime(const std::string& file, time_t* m_time) {
+    int fd = open(file.c_str(), O_RDONLY);

Review Comment:
   use a defer to protect fd maybe mor simple



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to