morrySnow commented on code in PR #12008:
URL: https://github.com/apache/doris/pull/12008#discussion_r952988304
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java:
##########
@@ -55,12 +58,9 @@ public class CostAndEnforcerJob extends Job implements
Cloneable {
private List<GroupExpression> childrenBestGroupExprList;
private final List<PhysicalProperties> childrenOutputProperty =
Lists.newArrayList();
- // Current stage of enumeration through child groups
private int curChildIndex = -1;
- // Indicator of last child group that we waited for optimization
Review Comment:
why remove these comments
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java:
##########
@@ -99,22 +99,26 @@ public CostAndEnforcerJob(GroupExpression groupExpression,
JobContext context) {
public void execute() {
// Do init logic of root plan/groupExpr of `subplan`, only run once
per task.
if (curChildIndex == -1) {
- curTotalCost = 0;
-
- // Get property from groupExpression plan (it's root of subplan).
- RequestPropertyDeriver requestPropertyDeriver = new
RequestPropertyDeriver(context);
- requestChildrenPropertyList =
requestPropertyDeriver.getRequestChildrenPropertyList(groupExpression);
-
+ curNodeCost = 0;
+ curTreeCost = 0;
curChildIndex = 0;
+ // List<request property to children>
+ // [ child item: [leftProperties, rightPropertie]]
+ // like :[ [Properties {"", ANY}, Properties {"", BROADCAST}],
+ // [Properties {"", SHUFFLE_JOIN}, Properties {"",
SHUFFLE_JOIN}] ]
+ requestChildrenPropertyList = (new RequestPropertyDeriver(context))
Review Comment:
i like the old code style 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
