morrySnow commented on code in PR #53376:
URL: https://github.com/apache/doris/pull/53376#discussion_r2214833703
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/AddColumnOp.java:
##########
@@ -125,12 +131,17 @@ public String toString() {
/**
* validateColumnDef
*/
- public static void validateColumnDef(TableNameInfo tableName,
ColumnDefinition columnDef, ColumnPosition colPos,
+ public void validateColumnDef(TableNameInfo tableName, ColumnDefinition
columnDef, ColumnPosition colPos,
String rollupName)
throws UserException {
if (columnDef == null) {
throw new AnalysisException("No column definition in add column
clause.");
}
+ if (columnDef.getName().startsWith(Column.HIDDEN_COLUMN_PREFIX) &&
!enableFeatureOp) {
Review Comment:
do not add here, add this check in
org.apache.doris.common.FeNameFormat#checkColumnName
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
