gavinchou commented on code in PR #53548:
URL: https://github.com/apache/doris/pull/53548#discussion_r2215457579
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -114,7 +116,7 @@
VerticalSegmentWriter::VerticalSegmentWriter(io::FileWriter* file_writer, uint32
for (size_t cid = 0; cid < _num_sort_key_columns; ++cid) {
const auto& column = _tablet_schema->column(cid);
_key_coders.push_back(get_key_coder(column.type()));
- _key_index_size.push_back(column.index_length());
+
_key_index_size.push_back(static_cast<uint16_t>(column.index_length()));
Review Comment:
用cast_set<>()这个cast, 在cast_set.h定义的
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -135,7 +137,7 @@
VerticalSegmentWriter::VerticalSegmentWriter(io::FileWriter* file_writer, uint32
for (auto cid : _tablet_schema->cluster_key_uids()) {
const auto& column = _tablet_schema->column_by_uid(cid);
_key_coders.push_back(get_key_coder(column.type()));
- _key_index_size.push_back(column.index_length());
+
_key_index_size.push_back(static_cast<uint16_t>(column.index_length()));
Review Comment:
用cast_set<>()这个cast, 在cast_set.h定义的
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -149,7 +151,7 @@ void VerticalSegmentWriter::_init_column_meta(ColumnMetaPB*
meta, uint32_t colum
const TabletColumn& column) {
meta->set_column_id(column_id);
meta->set_type(int(column.type()));
- meta->set_length(column.length());
+ meta->set_length(static_cast<int32_t>(column.length()));
Review Comment:
用cast_set<>()这个cast, 在cast_set.h定义的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
