HappenLee commented on code in PR #12017:
URL: https://github.com/apache/doris/pull/12017#discussion_r953287393
##########
be/src/vec/sink/vdata_stream_sender.cpp:
##########
@@ -103,15 +107,16 @@ Status VDataStreamSender::Channel::send_local_block(bool
eos) {
std::shared_ptr<VDataStreamRecvr> recvr =
_parent->state()->exec_env()->vstream_mgr()->find_recvr(_fragment_instance_id,
_dest_node_id);
+ Block block = _mutable_block->to_block();
if (recvr != nullptr) {
- Block block = _mutable_block->to_block();
COUNTER_UPDATE(_parent->_local_bytes_send_counter, block.bytes());
+ COUNTER_UPDATE(_parent->_local_sent_rows, block.rows());
recvr->add_block(&block, _parent->_sender_id, true);
if (eos) {
recvr->remove_sender(_parent->_sender_id, _be_number);
}
}
- _mutable_block->clear();
+ _mutable_block->set_muatable_columns(block.clone_empty_columns());
Review Comment:
move to line 111
##########
be/src/vec/runtime/vdata_stream_recvr.cpp:
##########
@@ -155,9 +155,7 @@ void VDataStreamRecvr::SenderQueue::add_block(Block* block,
bool use_move) {
nblock->info = block->info;
// local exchange should copy the block contented if use move == false
- if (use_move) {
Review Comment:
why delete the code here？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
