This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new fb77c021674 branch-3.1: [Enhancement](Log) Missing rowset clone should
not print stack log #53193 (#53526)
fb77c021674 is described below
commit fb77c021674fd863ee3699d79f4674a786c715a7
Author: abmdocrt <[email protected]>
AuthorDate: Sat Jul 19 09:27:56 2025 +0800
branch-3.1: [Enhancement](Log) Missing rowset clone should not print stack
log #53193 (#53526)
Pick #53193
---
be/src/olap/cumulative_compaction.cpp | 2 +-
be/src/olap/storage_engine.cpp | 5 +++--
be/src/olap/task/engine_publish_version_task.cpp | 2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/be/src/olap/cumulative_compaction.cpp
b/be/src/olap/cumulative_compaction.cpp
index 2a2fdb51eb2..8db397aa577 100644
--- a/be/src/olap/cumulative_compaction.cpp
+++ b/be/src/olap/cumulative_compaction.cpp
@@ -206,7 +206,7 @@ Status CumulativeCompaction::pick_rowsets_to_compact() {
Status st = _engine.submit_clone_task(tablet(),
missing_versions.back().first);
if (!st) {
LOG_WARNING("cumulative compaction failed to submit missing
rowset clone task.")
- .tag("st", st.to_string())
+ .tag("st", st.msg())
.tag("tablet_id", _tablet->tablet_id())
.tag("version", missing_versions.back().first)
.tag("replica_id", tablet()->replica_id())
diff --git a/be/src/olap/storage_engine.cpp b/be/src/olap/storage_engine.cpp
index d119e197d93..69a315b4fe5 100644
--- a/be/src/olap/storage_engine.cpp
+++ b/be/src/olap/storage_engine.cpp
@@ -1521,6 +1521,7 @@ bool StorageEngine::get_peers_replica_backends(int64_t
tablet_id, std::vector<TB
int64_t cur_time = UnixMillis();
if (cur_time - _last_get_peers_replica_backends_time_ms < 10000) {
LOG_WARNING("failed to get peers replica backens.")
+ .tag("tablet_id", tablet_id)
.tag("last time", _last_get_peers_replica_backends_time_ms)
.tag("cur time", cur_time);
return false;
@@ -1702,8 +1703,8 @@ Status StorageEngine::_persist_broken_paths() {
Status StorageEngine::submit_clone_task(Tablet* tablet, int64_t version) {
std::vector<TBackend> backends;
if (!get_peers_replica_backends(tablet->tablet_id(), &backends)) {
- LOG(WARNING) << tablet->tablet_id() << " tablet doesn't have peer
replica backends";
- return Status::InternalError("");
+ return Status::Error<ErrorCode::INTERNAL_ERROR, false>(
+ "get_peers_replica_backends failed.");
}
TAgentTaskRequest task;
TCloneReq req;
diff --git a/be/src/olap/task/engine_publish_version_task.cpp
b/be/src/olap/task/engine_publish_version_task.cpp
index 6c37e55da75..13e7dcd97aa 100644
--- a/be/src/olap/task/engine_publish_version_task.cpp
+++ b/be/src/olap/task/engine_publish_version_task.cpp
@@ -228,7 +228,7 @@ Status EnginePublishVersionTask::execute() {
if (!st) {
LOG_WARNING(
"mow publish failed to submit missing
rowset clone task.")
- .tag("st", st.to_string())
+ .tag("st", st.msg())
.tag("tablet_id", tablet->tablet_id())
.tag("version", version.first - 1)
.tag("replica_id",
tablet->replica_id())
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
