CalvinKirs commented on code in PR #53592:
URL: https://github.com/apache/doris/pull/53592#discussion_r2218106639
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/storage/AbstractS3CompatibleProperties.java:
##########
@@ -168,6 +169,10 @@ public AwsCredentialsProvider getAwsCredentialsProvider() {
sessionToken));
}
}
+ // For anonymous access (no credentials required)
+ if (StringUtils.isBlank(getAccessKey()) &&
StringUtils.isBlank(getSecretKey())) {
+ return AnonymousCredentialsProvider.create();
+ }
Review Comment:
This setup allows COS/OBS/OSS to be accessed without credentials. Have you
tested whether they actually permit this kind of access?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
