zhannngchen commented on code in PR #12044:
URL: https://github.com/apache/doris/pull/12044#discussion_r953629112
##########
be/src/olap/txn_manager.cpp:
##########
@@ -309,6 +309,9 @@ Status TxnManager::publish_txn(OlapMeta* meta, TPartitionId
partition_id,
// save meta need access disk, it maybe very slow, so that it is not
in global txn lock
// it is under a single txn lock
if (rowset_ptr != nullptr) {
+ // TODO(ygl): rowset is already set version here, memory is
changed, if save failed
Review Comment:
The comments should be removed? L336 returned an OLAPInternalError
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
