gavinchou commented on code in PR #53365:
URL: https://github.com/apache/doris/pull/53365#discussion_r2219052883
##########
gensrc/proto/cloud.proto:
##########
@@ -661,9 +661,10 @@ message CommitPartitionLogPB {
message DropPartitionLogPB {
optional int64 db_id = 1;
optional int64 table_id = 2;
- optional int64 index_id = 3;
- optional int64 partition_id = 4;
- optional RecyclePartitionPB recycle_partition = 5;
+ repeated int64 index_ids = 3;
+ repeated int64 partition_ids = 4;
+ optional int64 expiration = 5; // expiration timestamp
Review Comment:
这个命名可能需要体现一下是ms 或者 s 单位, 目前回收逻辑里 expiration这种字段 有一点乱. 有毫秒有秒, 有时间戳 有 超时.
名字里最好体现清楚一些.
比如 expired_at_s 或者 expiration_ts_ms等等
备份恢复功能类似字段先保证意义明确并且统一命名, 后去再去解决历史遗留问题.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
